test(session-manager): add positive-path tests for todos and transcript#1741
test(session-manager): add positive-path tests for todos and transcript#1741danpung2 wants to merge 1 commit intocode-yeongyu:devfrom
Conversation
|
All contributors have signed the CLA. Thank you! ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: Cannot be 100% sure no regressions. The PR adds readSessionTranscript to imports but no implementation is shown in the diff - risk of undefined function. Also, new test expects lineCount=4 but logic
|
Thank you for taking the time to add test coverage! We appreciate the effort. However, after review we've decided not to merge this one — the functions being tested are straightforward enough that the positive-path tests don't add meaningful safety net value. We'd love to see contributions on more complex areas where test coverage would really make a difference. Thanks again! 🙏 |
2 participants
Summary
Changes
readSessionTodoshappy-path test using a session-matching todo JSON filereadSessionTranscripthappy-path test counting non-empty lines in.jsonlTesting
bun run typecheck bun testSummary by cubic
Add happy-path tests for session-manager storage to verify todo parsing and transcript line counting.
Covers readSessionTodos mapping from a matching JSON file and readSessionTranscript returning the count of non-empty lines in .jsonl.
Written for commit 6a050a3. Summary will update on new commits.